Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable codecov #126

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Enable codecov #126

merged 2 commits into from
Oct 4, 2020

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 4, 2020 •
edited
Loading

The codecov test panics were due to this change, mentioned on this and this issue. The error backtrace is:

test api::vcx::tests::test_import_after_init_fails ... thread '<unnamed>' panicked at 'attempted to leave type `linked_hash_map::Node<std::string::String, raw_statement::RawStatement>` uninitialized, which is invalid', /rustc/25c8c53dd994acb3f4f7c02fe6bb46076393f8b0/library/core/src/mem/mod.rs:658:9
stack backtrace:
   0: rust_begin_unwind
             at /rustc/25c8c53dd994acb3f4f7c02fe6bb46076393f8b0/library/std/src/panicking.rs:483
   1: core::panicking::panic_fmt
             at /rustc/25c8c53dd994acb3f4f7c02fe6bb46076393f8b0/library/core/src/panicking.rs:85
   2: core::panicking::panic
             at /rustc/25c8c53dd994acb3f4f7c02fe6bb46076393f8b0/library/core/src/panicking.rs:50
   3: linked_hash_map::LinkedHashMap<K,V,S>::insert
   4: <rusqlite::cache::CachedStatement as core::ops::drop::Drop>::drop
   5: <indy_wallet::storage::default::SQLiteStorage as indy_wallet::storage::WalletStorage>::add
   6: indy_wallet::wallet::Wallet::add
   7: indy_wallet::WalletService::add_record
   8: indy_wallet::WalletService::add_indy_object
   9: indy::commands::did::DidCommandExecutor::execute
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

To read: https://doc.rust-lang.org/nomicon/unchecked-uninit.html

mirgee added 2 commits October 4, 2020 13:38
@mirgee
Try enabling codecov
782895a 
Signed-off-by: Miroslav Kovar <[email protected]>
@mirgee
Use older rustc to compile libindy
dc20cfb 
Signed-off-by: Miroslav Kovar <[email protected]>
@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented Oct 4, 2020 •
edited
Loading

Perhaps could be fixed by updating rusqlite from which the error seems to be originating, libindy is now using 0.20.0, but 0.24.0 is available.
https://github.com/rusqlite/rusqlite/releases

Anyway, for codecov restoreation this fix this is ofcourse good enough. Good investigation 👍

@Patrik-Stas Patrik-Stas merged commit dc66c75 into master Oct 4, 2020
@Patrik-Stas Patrik-Stas deleted the enable-codecov branch October 5, 2020 08:23
@mirgee mirgee mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrik-Stas Patrik-Stas Patrik-Stas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirgee @Patrik-Stas